From eb5b9cca9a039624e33e2dd9388c924245735d46 Mon Sep 17 00:00:00 2001 From: oblonski Date: Tue, 29 Sep 2015 08:56:11 +0200 Subject: [PATCH] reproduce and fix #190 --- .../main/java/jsprit/core/problem/Skills.java | 2 +- .../java/jsprit/core/problem/SkillsTest.java | 26 +++++++++++++++++++ 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/jsprit-core/src/main/java/jsprit/core/problem/Skills.java b/jsprit-core/src/main/java/jsprit/core/problem/Skills.java index 6905ba9f..ba5d255f 100644 --- a/jsprit-core/src/main/java/jsprit/core/problem/Skills.java +++ b/jsprit-core/src/main/java/jsprit/core/problem/Skills.java @@ -47,7 +47,7 @@ public class Skills { * @return builder */ public Builder addSkill(String skill) { - skills.add(skill.toLowerCase()); + skills.add(skill.trim().toLowerCase()); return this; } diff --git a/jsprit-core/src/test/java/jsprit/core/problem/SkillsTest.java b/jsprit-core/src/test/java/jsprit/core/problem/SkillsTest.java index 17706ca3..263fce72 100644 --- a/jsprit-core/src/test/java/jsprit/core/problem/SkillsTest.java +++ b/jsprit-core/src/test/java/jsprit/core/problem/SkillsTest.java @@ -63,4 +63,30 @@ public class SkillsTest { assertTrue(skills.containsSkill("skill2")); } + @Test + public void whenSkillsAddedPrecedingWhitespaceShouldNotMatter() { + Set skillSet = new HashSet(); + skillSet.add(" skill1"); + skillSet.add("Skill2"); + Skills skills = Skills.Builder.newInstance().addAllSkills(skillSet).build(); + assertTrue(skills.containsSkill("skill1")); + assertTrue(skills.containsSkill("skill2")); + } + + @Test + public void whenSkillsAddedTrailingWhitespaceShouldNotMatter() { + Set skillSet = new HashSet(); + skillSet.add("skill1 "); + skillSet.add("Skill2"); + Skills skills = Skills.Builder.newInstance().addAllSkills(skillSet).build(); + assertTrue(skills.containsSkill("skill1")); + assertTrue(skills.containsSkill("skill2")); + } + + @Test + public void whenSkillsAddedTrailingWhitespaceShouldNotMatter2() { + Skills skills = Skills.Builder.newInstance().addSkill("skill1 ").build(); + assertTrue(skills.containsSkill("skill1")); + } + }